From e4e72a29ae274b75d1b6d3d4a24708b3dbba9281 Mon Sep 17 00:00:00 2001 From: NIIBE Yutaka Date: Wed, 19 Jul 2017 11:55:20 +0900 Subject: [PATCH] Initialize TMP to avoid confusion by static analysis. -- The computation using TMP is keeping it constant-time only, but it is better not to confuse static analysis. Signed-off-by: NIIBE Yutaka --- ChangeLog | 2 ++ src/mod.c | 1 + 2 files changed, 3 insertions(+) diff --git a/ChangeLog b/ChangeLog index 292dab4..751e7d2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2017-07-19 NIIBE Yutaka + * src/mod.c (mod_inv): Clear TMP. + * src/configure (REVISION): Generate even when no git. * polarssl/library/bignum.c (mpi_exp_mod): Call mpi_grow for X diff --git a/src/mod.c b/src/mod.c index bd4de24..340fc16 100644 --- a/src/mod.c +++ b/src/mod.c @@ -156,6 +156,7 @@ mod_inv (bn256 *C, const bn256 *X, const bn256 *N) #define borrow carry int n = MAX_GCD_STEPS_BN256; + memset (tmp, 0, sizeof (bn256)); memset (C, 0, sizeof (bn256)); memcpy (u, X, sizeof (bn256)); memcpy (v, N, sizeof (bn256));