deon/gnuk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove Ed25519 signing condition against EDDSA_HASH_LEN_MAX.

Browse Source 
See GnuPG bug report: https://dev.gnupg.org/T5041

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
This commit is contained in:
NIIBE Yutaka
2020-09-03 10:42:20 +09:00
parent 934daf3585
commit bf30144144
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@@ -1,3 +1,9 @@
2020-09-03 NIIBE Yutaka <gniibe@fsij.org>
* src/openpgp.c (cmd_internal_authenticate): Remove checking
against EDDSA_HASH_LEN_MAX.
(cmd_pso): Likewise.
2020-08-28 NIIBE Yutaka <gniibe@fsij.org> 2020-08-28 NIIBE Yutaka <gniibe@fsij.org>
* src/openpgp.c (cmd_reset_user_password): Add passphrase length * src/openpgp.c (cmd_reset_user_password): Add passphrase length

14
src/openpgp.c
View File

@@ -1005,13 +1005,6 @@ cmd_pso (struct eventflag *ccid_comm)
{ {
uint32_t output[64/4]; /* Require 4-byte alignment. */ uint32_t output[64/4]; /* Require 4-byte alignment. */
if (len > EDDSA_HASH_LEN_MAX)
{
DEBUG_INFO ("wrong hash length.");
GPG_CONDITION_NOT_SATISFIED ();
return;
}
cs = chopstx_setcancelstate (0); cs = chopstx_setcancelstate (0);
result_len = EDDSA_SIGNATURE_LENGTH; result_len = EDDSA_SIGNATURE_LENGTH;
r = eddsa_sign_25519 (apdu.cmd_apdu_data, len, output, r = eddsa_sign_25519 (apdu.cmd_apdu_data, len, output,
@@ -1218,13 +1211,6 @@ cmd_internal_authenticate (struct eventflag *ccid_comm)
{ {
uint32_t output[64/4]; /* Require 4-byte alignment. */ uint32_t output[64/4]; /* Require 4-byte alignment. */
if (len > EDDSA_HASH_LEN_MAX)
{
DEBUG_INFO ("wrong hash length.");
GPG_CONDITION_NOT_SATISFIED ();
return;
}
cs = chopstx_setcancelstate (0); cs = chopstx_setcancelstate (0);
result_len = EDDSA_SIGNATURE_LENGTH; result_len = EDDSA_SIGNATURE_LENGTH;
r = eddsa_sign_25519 (apdu.cmd_apdu_data, len, output, r = eddsa_sign_25519 (apdu.cmd_apdu_data, len, output,