From 2622840e277783d7110377f3a2a69a173b44b9dd Mon Sep 17 00:00:00 2001 From: Anthony Romano Date: Sun, 16 Jul 2017 19:40:49 -0700 Subject: [PATCH] remove unused calculations from mod_reduce. Detected with scan-build. Signed-off-by: Anthony Romano --- AUTHORS | 6 ++++++ ChangeLog | 4 ++++ THANKS | 1 + src/mod.c | 5 +---- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/AUTHORS b/AUTHORS index bd4c10d..1e5c78d 100644 --- a/AUTHORS +++ b/AUTHORS @@ -1,3 +1,9 @@ +Anthony Romano: + Modified: + src/call-rsa.c + src/main.c + src/mod.c + Kaz Kojima: Added STM32 Primer2 support. diff --git a/ChangeLog b/ChangeLog index 9aec6c6..06ea2d8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2017-07-18 Anthony Romano + + * src/mod.c (mod_reduce): Clean up unused code. + 2017-07-18 Anthony Romano * src/call-rsa.c (modulus_calc): Free modulus on error. diff --git a/THANKS b/THANKS index 9dd5d09..47a328b 100644 --- a/THANKS +++ b/THANKS @@ -11,6 +11,7 @@ Achim Pietig achim@pietig.com Aidan Thornton Anibal Monsalve Salazar anibal@debian.org Andre Zepezauer andre.zepezauer@student.uni-halle.de +Anthony Romano anthony.romano@coreos.com Bertrand Jacquin bertrand@jacquin.bzh Clint Adams clint@softwarefreedom.org Daniel Kahn Gillmor dkg@fifthhorseman.net diff --git a/src/mod.c b/src/mod.c index a1cbc1f..bd4de24 100644 --- a/src/mod.c +++ b/src/mod.c @@ -36,7 +36,6 @@ mod_reduce (bn256 *X, const bn512 *A, const bn256 *B, const bn256 *MU_lower) bn512 q_big[1], tmp[1]; uint32_t carry; #define borrow carry - uint32_t borrow_next; memset (q, 0, sizeof (bn256)); q->word[0] = A->word[15]; @@ -110,9 +109,7 @@ mod_reduce (bn256 *X, const bn512 *A, const bn256 *B, const bn256 *MU_lower) = tmp->word[11] = tmp->word[10] = tmp->word[9] = 0; borrow = bn256_sub (X, (bn256 *)&q_big->word[0], (bn256 *)&tmp->word[0]); - borrow_next = (q_big->word[8] < borrow); q_big->word[8] -= borrow; - borrow_next += (q_big->word[8] < tmp->word[8]); q_big->word[8] -= tmp->word[8]; carry = q_big->word[8]; @@ -122,7 +119,7 @@ mod_reduce (bn256 *X, const bn512 *A, const bn256 *B, const bn256 *MU_lower) bn256_sub (q, X, B); if (carry) - carry -= bn256_sub (X, X, B); + bn256_sub (X, X, B); else bn256_sub (q, X, B);